search

kubernetes / kompose

Convert Compose to Kubernetes
http://kompose.io
Apache License 2.0
9.65k stars 764 forks source link

Docker networks #1943

Open LucasAguirre99 opened 1 month ago

LucasAguirre99 commented 1 month ago

What would you like to be added?

When performing the conversion in a docker compose that has a network, the command fails, causing automated processes to stop the pipeline or development

Why is this needed?

I guess it would be a good alternative that when performing the conversion, if our compose has a network it will be skipped, so our processes can continue since the network is not important in kubernetes

stappersg commented 2 weeks ago

It feels wrong to skip network.

Regarding the

since the network is not important in kubernetes

Thing is that it is important for the Docker compose file.

LucasAguirre99 commented 2 weeks ago

Yes, what I mean is not that it is not present in the Dockerfile, I mean that if there is a defined network, kompose should skips it instead of failing, since it slows down many automations.

I don't know if I'm being clear

stappersg commented 2 weeks ago

On Mon, Nov 11, 2024 at 05:06:07AM -0800, Lucas Aguirre wrote:

I don't know if I'm being clear

Let me try a new attempt.

For the Docker compose file are network definitions important. Bailing out with an error on conversion has the benefit of drawing human attention. That is much better as "silent ignore", a.k.a. skipping. A websearch on "Chesters fence" might provide additional information.

Groeten Geert Stappers

P.S. Note to my further self: Let handle k8s-triage-bot handle this. -- Silence is hard to parse