Implement WarmPool on Terraform

kubernetes / kops

Kubernetes Operations (kOps) - Production Grade k8s Installation, Upgrades and Management

https://kops.sigs.k8s.io/

Apache License 2.0

15.94k stars 4.65k forks source link

Implement WarmPool on Terraform #11633

Closed johngmyers closed 1 year ago

johngmyers commented 3 years ago

1. Describe IN DETAIL the feature/behavior/change you would like to see.

Implement WarmPool.RenderTerraform()

2. Feel free to provide a design supporting your feature request.

/kind feature /area terraform /lifecycle frozen

Patil2099 commented 3 years ago

I am new to this project and would love to help in implementing this feature. Can you guide me a little? @johngmyers

johngmyers commented 3 years ago

The task is to implement WarmPool.RenderTerraform.

I would suggest looking at other RenderTerraform receivers to see how they work. You'll need to create an annotated struct corresponding to the Terraform configuration syntax.

Adding an integration test for warmpool would also be good. The integration tests are in kops/cmd/kops/integration_test.go.

johngmyers commented 3 years ago

It looks like Terraform puts this inside the ASG definition, so you'll probably have to put this in AutoscalingGroup.RenderTerraform instead.

sandeeppainuly commented 3 years ago

/assign

vnzongzna commented 3 years ago

/assign

JacekDuszenko commented 3 years ago

If others are not working on the task I'd like to look into it now, so am assigning myself.

JacekDuszenko commented 3 years ago

/assign @JacekDuszenko

rifelpet commented 3 years ago

The WarmPool task has an AutoScalingGroup reference field yet doesn't use it in any of its methods, I'm assuming this is for dependency purposes @olemarkus ? We likely can't add a WarmPool task reference in the ASG task because of the dependency loop, so we may need to wait for https://github.com/hashicorp/terraform-provider-aws/issues/19229 unless anyone has other ideas on how this could be implemented.

johngmyers commented 3 years ago

I believe for the Terraform target, the WarmPool task would do nothing. AutoscalingGroupModelBuilder would put the warmpool config into both the WarmPool and AutoscalingGroup tasks.

The trick would then be to keep the warmpool config in the AutoscalingGroup task from showing up in dryrun output.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

SD-13 commented 1 year ago

Seems like this PR addressed this issue. /close

k8s-ci-robot commented 1 year ago

@SD-13: Closing this issue.

In response to [this](https://github.com/kubernetes/kops/issues/11633#issuecomment-1783388697): >Seems like [this PR](https://github.com/kubernetes/kops/pull/15153) addressed this issue. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.