kubernetes / kops

Kubernetes Operations (kOps) - Production Grade k8s Installation, Upgrades and Management
https://kops.sigs.k8s.io/
Apache License 2.0
15.93k stars 4.65k forks source link

multiple asset containerProxys #15103

Closed benedikt-bartscher closed 1 year ago

benedikt-bartscher commented 1 year ago

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see. To overcome dockerhub rate limits, speed up pull times and increase availability we just started configuring registry mirros as a pull-trough cache. We setup clusterspec.containerd.registryMirrors for 5 different registries. However we noticed that kops assets won't get pulled trough the containerd registry mirrors. We then discovered clusterspec.assets.containerProxy but you can only define one containerProxy, not multiple for multiple registrys.

2. Feel free to provide a design supporting your feature request. Either just pull kops container assets trough the registrymirrors defined for containerd or allow configuring multiple asset containerProxys.

hakman commented 1 year ago

Could you try https://kops.sigs.k8s.io/cluster_spec/#containerregistry and see if that helps?

benedikt-bartscher commented 1 year ago

Hi @hakman, how would that help defining multiple servers?

hakman commented 1 year ago

There is no way to define multiple servers. It just normalises the paths to have mirror to a single ECR.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

olemarkus commented 1 year ago

Which container assets aren't pulled through containerd-configured mirrors? Aren't they pulled as any other container through CRI?

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/kops/issues/15103#issuecomment-1623501562): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.