Open danports opened 1 year ago
Can confirm, have same issue
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
We seem to have a similar issue. So just to check, what did you have as MixedOnDemandAllocationStrategy
prior to apply? Was it the default prioritized
?
In our case we created the group initially with MixedOnDemandAllocationStrategy=prioritized
and then wanted to change it to MixedOnDemandAllocationStrategy=lowest-price
but it seems like the reconciliation algorithm doesn't check for that.
There is a check for the spot instances here: https://github.com/kubernetes/kops/blob/db26ad5e7f6f65164f731c90c4a1fcea87cd137f/upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go#L536-L539
However, there is no such check for the MixedOnDemandAllocationStrategy
which seems like the root cause why it is not detected.
Same seems to be the case here: https://github.com/kubernetes/kops/blob/db26ad5e7f6f65164f731c90c4a1fcea87cd137f/upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go#L431-L435
/remove-lifecycle rotten
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
/remove-lifecycle rotten
/kind bug
1. What
kops
version are you running? The commandkops version
, will display this information. 1.26.22. What Kubernetes version are you running?
kubectl version
will print the version if a cluster is running or provide the Kubernetes version specified as akops
flag. 1.26.33. What cloud provider are you using? AWS
4. What commands did you run? What is the simplest way to reproduce this issue? Deploy a cluster with an instance group that specifies some instance types under
spec.mixedInstancesPolicy.instances
. Then update the instance group manifest and replace that section with aninstanceRequirements
section, e.g.:5. What happened after the commands executed? When running
kops update cluster
with the updated instance group manifest, it gets stuck in a failure loop:FWIW, it doesn't matter whether
onDemandAllocationStrategy: lowest-price
is included in the manifest - the error is the same.6. What did you expect to happen? The existing ASG should have been updated with the instance requirements specified.
7. Please provide your cluster manifest. Execute
kops get --name my.example.com -o yaml
to display your cluster manifest. You may want to remove your cluster name and other sensitive information.See snippet above.
8. Please run the commands with most verbose logging by adding the
-v 10
flag. Paste the logs into this report, or in a gist and provide the gist link here.See above.
9. Anything else do we need to know?
Creating a new instance group with
instanceRequirements
specified works fine. Switching an existing instance group toinstanceRequirements
also works fine if you delete the existing ASG before runningkops update cluster
.