search

kubernetes / kops

Kubernetes Operations (kOps) - Production Grade k8s Installation, Upgrades and Management
https://kops.sigs.k8s.io/
Apache License 2.0
15.87k stars 4.64k forks source link

Automated cherry pick of #16572: Upgrade node-termination-handler to 1.22.0 #16595

Closed jim-barber-he closed 4 months ago

jim-barber-he commented 4 months ago

Cherry pick of #16572 on release-1.29.

16572: Upgrade node-termination-handler to 1.22.0

For details on the cherry pick process, see the cherry pick requests page.

k8s-ci-robot commented 4 months ago

Hi @jim-barber-he. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hakman commented 4 months ago

/ok-to-test

jim-barber-he commented 4 months ago

@hakman To fix the tests do I just checkout out the automated-cherry-pick-of-#16572-upstream-release-1.29 branch and run the hack/update-expected.sh script to update everything?

EDIT: I've done this and pushed the result since it changes a lot of what the tests were complaining about. I still have one failed test locally but not sure how to fix it

FAIL    k8s.io/kops/cmd/kops    600.099s

There was nothing else with the word fail in it. I found these things mentioning error

W0531 14:07:32.184899  284837 executor.go:141] error running task "Instance/control-plane-fr-par-1" (29s remaining to succeed): error opening resource: resource opened before it is ready (task=&{control-plane-fr-par-1 Sync 0xc001d29088 0xc001375808 0xc00170fef0 {<nil> 0xc001bb8d20} [0xc001bb8c80] map[apiserver-aggregator-ca:0xc000858180 etcd-clients-ca:0xc000859100 etcd-manager-ca-events:0xc000859980 etcd-manager-ca-main:0xc000859000 etcd-peers-ca-events:0xc000859a00 etcd-peers-ca-main:0xc000859080 kubernetes-ca:0xc000858100 service-account:0xc000858200] {<nil> 0xc001bb8d20}})
W0531 14:07:32.184916  284837 executor.go:141] error running task "Instance/nodes-fr-par-1" (29s remaining to succeed): error opening resource: resource opened before it is ready (task=&{nodes-fr-par-1 Sync 0xc001d29088 0xc001375c08 0xc00170fef0 {<nil> 0xc001bb8dc0} [0xc001bb8c80] map[etcd-clients-ca:0xc000859100 etcd-manager-ca-events:0xc000859980 etcd-manager-ca-main:0xc000859000 etcd-peers-ca-events:0xc000859a00 etcd-peers-ca-main:0xc000859080 kubernetes-ca:0xc000858100] {<nil> 0xc001bb8dc0}})
k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kops/blob/release-1.29/OWNERS)~~ [hakman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment