search

kubernetes / kops

Kubernetes Operations (kOps) - Production Grade k8s Installation, Upgrades and Management
https://kops.sigs.k8s.io/
Apache License 2.0
15.87k stars 4.64k forks source link

Don't truncate the top level domains for GCP jobs #16796

Closed rifelpet closed 1 month ago

rifelpet commented 1 month ago

Followup to https://github.com/kubernetes/kops/pull/16787

This test run is using e2e-pr127005.pull-kubernetes-e2e-gce-disruptive-canary.k8s.loca where it would be more appropriate to keep k8s.local and trim e2e-pr127005.pull-kubernetes-e2e-gce-disruptive-canary.

This PR updates the trim logic to end up with e2e-pr127005.pull-kubernetes-e2e-gce-disruptive-canar.k8s.local

/cc @dims @hakman

justinsb commented 1 month ago

Thanks @rifelpet

/approve /lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kops/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dims commented 1 month ago

thanks @rifelpet !