kubernetes / kops

Kubernetes Operations (kOps) - Production Grade k8s Installation, Upgrades and Management
https://kops.sigs.k8s.io/
Apache License 2.0
15.87k stars 4.64k forks source link

Limit GCP subnet secondary alias names to 63 chars #16808

Closed rifelpet closed 3 weeks ago

rifelpet commented 3 weeks ago

This should fix these GCP jobs that have long cluster names:

https://testgrid.k8s.io/kops-gce#ci-kubernetes-e2e-cos-gce-reboot-canary

Error: error running tasks: deadline exceeded executing task Subnet/us-central1-e2e-e2e-ci-kubernetes-e2e-cos-gce-reboot-can-a1ernl. Example error: error creating Subnet: googleapi: Error 400: Invalid value for field 'resource.secondaryIpRanges[1].rangeName': 'services-e2e-e2e-ci-kubernetes-e2e-cos-gce-reboot-canary-k8s-local'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)', invalid

https://github.com/kubernetes/kops/blob/3aad69c65530a0b5558227e4bc92f5428b90a06b/pkg/model/gcemodel/context.go#L75-L78

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kops/blob/master/OWNERS)~~ [hakman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment