[spotinst-controller] Error while fetching pods metrics

msessa commented 5 years ago

1. What kops version are you running? The command kops version, will display this information. 1.11.1

2. What Kubernetes version are you running? kubectl version will print the version if a cluster is running or provide the Kubernetes version specified as a kops flag. 1.11.7

3. What cloud provider are you using? AWS

4. What commands did you run? What is the simplest way to reproduce this issue?

Spin up a cluster with Spotinst feature flag enabled
Follow the spotinst-kubernetes-cluster-controller pod logs

The following error appears eventually:

ERROR  [DefaultQuartzScheduler_Worker-10] PushPodsMetricsCmd - Error while fetching pods metrics, Errors: [DalError{code='403', message='Message: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"pods.metrics.k8s.io is forbidden: User \"system:serviceaccount:kube-system:spotinst-kubernetes-cluster-controller\" cannot list pods.metrics.k8s.io at the cluster scope","reason":"Forbidden","details":{"group":"metrics.k8s.io","kind":"pods"},"code":403}
. Headers: {"Content-Type":["application/json"],"X-Content-Type-Options":["nosniff"],"Date":["Wed, 20 Mar 2019 11:45:18 GMT"],"Content-Length":["333"],"OkHttp-Sent-Millis":["1553082318396"],"OkHttp-Received-Millis":["1553082318397"]}'}]

9. Anything else do we need to know?

msessa commented 5 years ago

Added PR with a possible fix

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/kops/issues/6644#issuecomment-522239401): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kubernetes / kops

[spotinst-controller] Error while fetching pods metrics #6644