search

kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving
Apache License 2.0
319 stars 208 forks source link

Drop unused mapstructure functionality #390

Closed liggitt closed 1 year ago

liggitt commented 1 year ago

Cleans up unused dependency

apelisse commented 1 year ago

Looks good to me, but curious if @alexzielenski uses that?

liggitt commented 1 year ago

I think this was residual from the old go-openapi repos

liggitt commented 1 year ago

at least within k/k, there's no use (https://github.com/kubernetes/kubernetes/pull/118014 passed typecheck with it dropped)

alexzielenski commented 1 year ago

Looks good to me, but curious if @alexzielenski uses that?

nope, we are doing some things with strfmt in kubectl-validate but nothing regarding this mapstructure dep

liggitt commented 1 year ago

dropped WIP, ready whenever you are

alexzielenski commented 1 year ago

/lgtm

apelisse commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/OWNERS)~~ [apelisse] - ~~[pkg/validation/OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/pkg/validation/OWNERS)~~ [liggitt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment