search

kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving
Apache License 2.0
317 stars 205 forks source link

fixup broken test #414

Closed alexzielenski closed 1 year ago

alexzielenski commented 1 year ago

When merging #406 CI did not run the new test recently introduced in #412

This adds the missing objectValidator option causing NPE after merging both PRs

/cc @apelisse @sttts

sttts commented 1 year ago

/lgtm /approve

Why did the other PR merge without?

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/validation/OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/pkg/validation/OWNERS)~~ [sttts] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment