search

kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving
Apache License 2.0
317 stars 205 forks source link

Include missing param options in requestBody #428

Closed Jefftree closed 1 year ago

Jefftree commented 1 year ago

Include missing param options in requestBody.

Fixes: https://github.com/kubernetes/kube-openapi/issues/427

See k/k OpenAPI v3 diff at https://github.com/Jefftree/kubernetes/commit/43d92b108b929bfa8aaf492d5de8075e0f5da279

/assign @apelisse

apelisse commented 1 year ago

how is this not causing any test to change?

PS: Just noticed that the tests are failing :-)

apelisse commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/OWNERS)~~ [Jefftree,apelisse] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment