Separate OpenAPI V2 and V3 config in V3 builder

kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving

Apache License 2.0

317 stars 205 forks source link

Separate OpenAPI V2 and V3 config in V3 builder #431

Closed Jefftree closed 11 months ago

Jefftree commented 1 year ago

Decouple v2 and v3 configs to support https://github.com/kubernetes/kube-openapi/pull/420 properly

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/OWNERS)~~ [Jefftree] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Jefftree commented 12 months ago

/assign @apelisse Would appreciate your thoughts on this, thanks!

Jefftree commented 12 months ago

k/k PR is a bit more involved: https://github.com/kubernetes/kubernetes/pull/121010

apelisse commented 11 months ago

Yeah, I think the breaking change is fine here. LGTM, just one question.

apelisse commented 11 months ago

/lgtm