fix staticcheck - combine var declaration and assignment

kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving

Apache License 2.0

317 stars 205 forks source link

fix staticcheck - combine var declaration and assignment #433

Closed Jefftree closed 11 months ago

Jefftree commented 1 year ago

/assign @apelisse

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/OWNERS)~~ [Jefftree] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

apelisse commented 1 year ago

the best change ever! Do we not run staticchecks automatically in the CI?

Jefftree commented 12 months ago

@apelisse Yeah this is quite a lot haha. We can't do much about the json-experiment-library

Jefftree commented 11 months ago

Will rethink this PR since there are quite a lot of changes involved.