Closed Schnides123 closed 9 months ago
Welcome @Schnides123!
It looks like this is your first PR to kubernetes/kube-openapi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/kube-openapi has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/ok-to-test
@alexzielenski: GitHub didn't allow me to request PR reviews from the following users: WDYT, is, preferable.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
I would still add an intergration test. Create a new directory for value validation in https://github.com/kubernetes/kube-openapi/tree/master/test/integration/testdata, add some types in there with various validation markers, carefully follow the README including the notes at the bottom. Thanks!
I have been told to add the prefix back in, so the prefix is now back in
/label tide/merge-method-squash /lgtm
/hold
can you squash (tide concats the descriptions which is not useful)
edit: i squashed for you
/ok-to-test
/hold cancel /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alexzielenski, Schnides123
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This PR adds the ability to annotate API fields with basic OpenAPI schema validations via marker comments, as part of the KEP-4153: Declarative Validation feature.
/assign @alexzielenski