kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving
Apache License 2.0
319 stars 208 forks source link

Do not require listType on []byte fields #437

Closed thockin closed 1 year ago

thockin commented 1 year ago

@apelisse @liggitt

xref https://github.com/kubernetes/kubernetes/pull/121759#pullrequestreview-1715638392

liggitt commented 1 year ago

/lgtm

@apelisse can add approve

apelisse commented 1 year ago

Thanks! /lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/generators/rules/OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/pkg/generators/rules/OWNERS)~~ [apelisse] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment