search

kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving
Apache License 2.0
317 stars 205 forks source link

bugfix: dont throw error if +required is set with omitempty #455

Closed alexzielenski closed 7 months ago

alexzielenski commented 7 months ago

I had included a bug into previous PR #448 which throws an error if +required is set on an omitempty field which ran counter to my interests.

Took another stab at it, this time including tests :)

/assign @Jefftree sorry for the churn.

/hold

Am also going to try to pin dep after this one so will wait for green PR there before merging this

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/OWNERS)~~ [alexzielenski] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alexzielenski commented 7 months ago

added another commit to fix another bug that was exposed when i pulled the changes into k/k. Newly evaluated enums sometimes alias each other and cause duplicate entries.

Jefftree commented 7 months ago

/lgtm

alexzielenski commented 7 months ago

/hold cancel