Closed lucacome closed 2 months ago
Looks like a type change in gengo: https://github.com/kubernetes/gengo/commit/2a31dd793ca4951ebf250828ad09654bceb47e23.
Reverting gengo so we can update it in a separate PR
@Jefftree can we merge this?
hey, sorry been super busy with code freeze. Would you mind opening a k/k PR just to make sure tests are passing? I can also do it later this week.
Do you mean after these changes are merged? If so I already have a PR up that I'm going to update https://github.com/kubernetes/kubernetes/pull/124632
Before the changes are merged by creating a temp PR pinned to your kube-openapi update branch and verifying the tests have no problems
./hack/pin-dependency.sh k8s.io/kube-openapi=github.com/lucacome/kube-openapi bump-deps
https://github.com/kubernetes/kubernetes/blob/6a95d2048e3dbb51db0e10a50d021a2e77ce79a3/go.mod#L248
Created the test PR here: https://github.com/kubernetes/kubernetes/pull/126362
oh I didn't know you could pin it like that, cool!
tests look good! /lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Jefftree, lucacome
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Bumps all the dependencies to the latest version available. Hopefully after this dependabot will start behaving...