kubernetes / kube-openapi

Kubernetes OpenAPI spec generation & serving
Apache License 2.0
317 stars 205 forks source link

Bump all Go dependencies #489

Closed lucacome closed 2 months ago

lucacome commented 2 months ago

Bumps all the dependencies to the latest version available. Hopefully after this dependabot will start behaving...

Jefftree commented 2 months ago

Looks like a type change in gengo: https://github.com/kubernetes/gengo/commit/2a31dd793ca4951ebf250828ad09654bceb47e23.

lucacome commented 2 months ago

Reverting gengo so we can update it in a separate PR

lucacome commented 2 months ago

@Jefftree can we merge this?

Jefftree commented 2 months ago

hey, sorry been super busy with code freeze. Would you mind opening a k/k PR just to make sure tests are passing? I can also do it later this week.

lucacome commented 2 months ago

Do you mean after these changes are merged? If so I already have a PR up that I'm going to update https://github.com/kubernetes/kubernetes/pull/124632

Jefftree commented 2 months ago

Before the changes are merged by creating a temp PR pinned to your kube-openapi update branch and verifying the tests have no problems

./hack/pin-dependency.sh k8s.io/kube-openapi=github.com/lucacome/kube-openapi bump-deps

https://github.com/kubernetes/kubernetes/blob/6a95d2048e3dbb51db0e10a50d021a2e77ce79a3/go.mod#L248

Created the test PR here: https://github.com/kubernetes/kubernetes/pull/126362

lucacome commented 2 months ago

oh I didn't know you could pin it like that, cool!

Jefftree commented 2 months ago

tests look good! /lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, lucacome

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-openapi/blob/master/OWNERS)~~ [Jefftree] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment