Closed pohly closed 4 weeks ago
/lgtm /approve
Using this in Kubernetes might be tricky, updating the dependency wasn't straight-forward - see https://github.com/kubernetes/kubernetes/pull/126917 (not including this PR yet).
~try rebasing, some other fixups went in last week (https://github.com/kubernetes/kube-openapi/pull/507, https://github.com/kubernetes/kube-openapi/pull/508)~
I'd recommend waiting until https://github.com/kubernetes/kubernetes/pull/126787 gets in and handles the regen cleanup
/lgtm
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Jefftree, liggitt, pohly
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This catches the following mistake:
The "listMeta" name matches the Go field name, but the convention is to call that JSON field "metadata".
The same applies to
ObjectMeta
.While at it, usage of the empty JSON name also gets checked more thoroughly. This is a mistake which was not detected earlier: