search

kubernetes / kube-scheduler

kube-scheduler component configs
Apache License 2.0
168 stars 76 forks source link

v1.KubeSchedulerConfiguration is not compatible with controller-gen #6

Closed ahmetb closed 6 months ago

ahmetb commented 6 months ago

I am using the kubescheduler.config.k8s.io/v1.KubeSchedulerConfiguration type as a field in my CustomResourceDefinition. However, when I try to generate CRD manifests from the Go type for the CRD using the command I get various errors.

I'm curious if this use case is supported. It can help projects like kubeadm, Cluster API or Kamaji.

Errors encountered

A few errors about float types (presumably QPS/Burst) in the componentbaseconfigv1alpha1.ClientConnectionConfiguration:

/Users/abalkan/go-athens/pkg/mod/k8s.io/component-base@v0.29.1/config/v1alpha1/types.go:79:6: found float, the usage of which is highly discouraged, as support for them varies across languages. Please consider serializing your float as string instead. If you are really sure you want to use them, re-run with crd:allowDangerousTypes=true

And a few errors about various []byte fields that have +listType=atomic:

/Users/abalkan/go-athens/pkg/mod/k8s.io/kube-scheduler@v0.29.1/config/v1/types.go:388:2: must apply listType to an array, found string

/Users/abalkan/go-athens/pkg/mod/k8s.io/kube-scheduler@v0.29.1/config/v1/types.go:392:2: must apply listType to an array, found string

/Users/abalkan/go-athens/pkg/mod/k8s.io/kube-scheduler@v0.29.1/config/v1/types.go:396:2: must apply listType to an array, found string

/kind support

ahmetb commented 6 months ago

Closing in favor of https://github.com/kubernetes/kubernetes/issues/124201