Closed tlereste closed 3 years ago
Thanks for filing this issue. We are fine with moving to the new apiVersion once the K8s 1.18.x dependencies are added to ksm. Please feel free to contribute that as a PR if you wish :)
Thanks ! I will do that :) /assign
I tried to update KSM to use K8S 1.18.2.
Unfortunately, vertical-pod-autoscaler
is not yet compatible with client-go v0.18.x.
I have the following errors :
vendor/k8s.io/autoscaler/vertical-pod-autoscaler/pkg/client/clientset/versioned/typed/autoscaling.k8s.io/v1/verticalpodautoscaler.go:74:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("verticalpodautoscalers").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
have ()
want (context.Context)
Because now client-go rest request must set context on Do call : https://github.com/kubernetes/client-go/blob/5159cff060fb98cd98592f6663f322c982066d7e/rest/request.go#L939
VPA use a old client-go version : v0.0.0-20191109102209-3c0d1af94be5 since November 15, 2019.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close
@fejta-bot: Closing this issue.
To follow issue #802 : kube-state-metrics still use deprecated Ingress API version
extensions/v1beta1
forIngress
resources.The blog post : https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ have been updated and now says that Ingress API version
extensions/v1beta1
will be removed in v1.22.The Ingress API version has been deprecated since v1.14.
Should we keep it more or update now ?