search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.4k stars 2.01k forks source link

Update deprecated Ingress API version ? #1127

Closed tlereste closed 3 years ago

tlereste commented 4 years ago

To follow issue #802 : kube-state-metrics still use deprecated Ingress API version extensions/v1beta1 for Ingress resources.

The blog post : https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ have been updated and now says that Ingress API version extensions/v1beta1 will be removed in v1.22.

The Ingress API version has been deprecated since v1.14.

Should we keep it more or update now ?

tariq1890 commented 4 years ago

Thanks for filing this issue. We are fine with moving to the new apiVersion once the K8s 1.18.x dependencies are added to ksm. Please feel free to contribute that as a PR if you wish :)

tlereste commented 4 years ago

Thanks ! I will do that :) /assign

tlereste commented 4 years ago

I tried to update KSM to use K8S 1.18.2. Unfortunately, vertical-pod-autoscaler is not yet compatible with client-go v0.18.x.

I have the following errors : 

vendor/k8s.io/autoscaler/vertical-pod-autoscaler/pkg/client/clientset/versioned/typed/autoscaling.k8s.io/v1/verticalpodautoscaler.go:74:5: not enough arguments in call to c.client.Get().Namespace(c.ns).Resource("verticalpodautoscalers").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do
        have ()
        want (context.Context)

Because now client-go rest request must set context on Do call : https://github.com/kubernetes/client-go/blob/5159cff060fb98cd98592f6663f322c982066d7e/rest/request.go#L939

VPA use a old client-go version : v0.0.0-20191109102209-3c0d1af94be5 since November 15, 2019.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

tariq1890 commented 4 years ago

/remove-lifecycle stale

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/kube-state-metrics/issues/1127#issuecomment-751052042): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.