Presubmit checks for stable metrics

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.

https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/

Apache License 2.0

5.38k stars 2.01k forks source link

Presubmit checks for stable metrics #1833

Open CatherineF-dev opened 2 years ago

CatherineF-dev commented 2 years ago

What would you like to be added: A presubmit to validate stable metrics don't change metric name, add labels or delete labels.

Why is this needed: Guarantee stable metrics are stable.

Due to lack of presubmit check, some stable metrics are changed. For example,

stable metric kube_persistentvolume_info is changed in https://github.com/kubernetes/kube-state-metrics/pull/1814
stable metric kube_service_status_load_balancer_ingress is changed in https://github.com/kubernetes/kube-state-metrics/pull/1687

Describe the solution you'd like

Import k8s metrics stability framework https://github.com/kubernetes/kube-state-metrics/pull/1844 and https://github.com/kubernetes/kube-state-metrics/pull/1976
Presubmit check https://github.com/kubernetes/kube-state-metrics/pull/1836

Additional context

CatherineF-dev commented 2 years ago

/open

CatherineF-dev commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@CatherineF-dev: Reopened this issue.

In response to [this](https://github.com/kubernetes/kube-state-metrics/issues/1833#issuecomment-1419601871): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

CatherineF-dev commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@CatherineF-dev: Reopened this issue.

In response to [this](https://github.com/kubernetes/kube-state-metrics/issues/1833#issuecomment-1421021204): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

logicalhan commented 1 year ago

/triage accepted /assign @CatherineF-dev

k8s-triage-robot commented 8 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

Confirm that this issue is still relevant with /triage accepted (org members only)
Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

CatherineF-dev commented 8 months ago

/triage accepted