kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.37k stars 2k forks source link

container label missing in kube_pod_status_container_ready_time #2053

Open bharathvenkatrajan opened 1 year ago

bharathvenkatrajan commented 1 year ago

What would you like to be added: kube_pod_status_container_ready_time should have the container label and be able to filter on a container level

https://github.com/kubernetes/kube-state-metrics/blob/main/docs/pod-metrics.md

Why is this needed: The metric kube_pod_status_container_ready_time is supposed to show the ready time for each container

Describe the solution you'd like Need to add the container label to the metric kube_pod_status_container_ready_time Adding a container label here? - https://github.com/kubernetes/kube-state-metrics/blob/main/internal/store/pod.go#L1339-L1364

dgrisonnet commented 1 year ago

/triage accepted /assign @CatherineF-dev

CatherineF-dev commented 1 year ago

The metric name should be kube_pod_container_ready_time.

You can add this new metric @bharathvenkatrajan with container label.

Example PR is https://github.com/kubernetes/kube-state-metrics/pull/1932

k8s-triage-robot commented 3 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

dgrisonnet commented 3 weeks ago

cc @Henrywu573

dgrisonnet commented 3 weeks ago

/triage accepted

Henrywu573 commented 3 weeks ago

/assign