Open CatherineF-dev opened 1 year ago
/assign
discovery imports many packages, which is similar to app package. Will move this under app.
util are highly coupled with custom resource state feature. Will move this under customresource.
It's better to have less many imports in an independent package
/triage accepted
This issue has not been updated in over 1 year, and should be re-triaged.
You can:
/triage accepted
(org members only)/close
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/
/remove-triage accepted
What happened: Encounter some cyclic imports errors after rebasing a WIP PR to master. It means the code structure is lowly cohesive/ highly coupling, or the WIP PR needs refactoring imports.
Compared dependencies and found these newly added dependencies:
What you expected to happen: Refactor some codes to make sure it's highly cohesive and lowly coupling.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl version
):