search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.21k stars 1.93k forks source link

feat: Support filtering annotations allowlist by "*" #2234

Closed xonvanetta closed 7 months ago

xonvanetta commented 8 months ago

What this PR does / why we need it: Same as #1823. Thought this was done on both allowlist since they are the same type but this wasn't the case. Added support for both now.

Support filtering label allowlist by "*", which will expand to the enabled resources, while inferring their values based on its value(s).

How does this change affect the cardinality of KSM: No change.

linux-foundation-easycla[bot] commented 8 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 8 months ago

Welcome @xonvanetta!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

CatherineF-dev commented 8 months ago

/lgtm

CatherineF-dev commented 8 months ago

Robot asked me to

/assign @mrueg

dashpole commented 8 months ago

/triage accepted

mrueg commented 7 months ago

/lgtm

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, mfld, mrueg, xonvanetta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/main/OWNERS)~~ [mrueg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment