search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.21k stars 1.93k forks source link

feat: add restartPolicy to `kube_pod_init_container_info` metric #2240

Closed changhyuni closed 6 months ago

changhyuni commented 7 months ago

What this PR does / why we need it:

This PR adds a label to kube_pod_init_container_info to track the restartPolicy set in the init_container With sidecar support starting with kubernetes 1.28, init_container can be used restartPolicy This metric tells you which pods are using the sidecar feature

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) adds a label that is never updated for a given init container

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 7 months ago

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mrueg commented 6 months ago

@changhyuni any plans to revive this one? This could be an interesting label

changhyuni commented 6 months ago

@mrueg I've reopened it. I'll fix the tests that are failing.

mrueg commented 6 months ago

/lgtm

Thanks for your contribution!

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: changhyuni, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/main/OWNERS)~~ [mrueg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment