search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.21k stars 1.93k forks source link

chore: Improve benchmark output #2272

Closed mrueg closed 6 months ago

mrueg commented 6 months ago

What this PR does / why we need it: Simply adds a suffix to the filenames so benchmarks will look like this and make it easier to know what to compare with each other.

pkg: k8s.io/kube-state-metrics/v2/pkg/app
                                   │ /tmp/tmp.eoDSvm8Gwf-main │         /tmp/tmp.tKQqwKPsmD-mybranch         │
                                   │       sec/op        │   sec/op     vs base                │
KubeStateMetrics/GenerateMetrics-4           1.001 ± ∞ ¹   1.001 ± ∞ ¹       ~ (p=1.000 n=1) ²
KubeStateMetrics/MakeRequests-4              7.805 ± ∞ ¹   7.627 ± ∞ ¹       ~ (p=1.000 n=1) ²
geomean                                      2.795         2.763        -1.15%
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) None Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 6 months ago

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rexagod commented 6 months ago

/lgtm

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/main/OWNERS)~~ [mrueg,rexagod] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment