search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.21k stars 1.93k forks source link

[PDNM] chore: comment bench results on PR #2273

Closed rexagod closed 1 month ago

rexagod commented 6 months ago

What this PR does / why we need it: Comment benchmark outputs on the PR, for better visibility, and to make sure we don't miss out on catching potential bottlenecks.

How does this change affect the cardinality of KSM: None.

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/main/OWNERS)~~ [rexagod] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mrueg commented 6 months ago

Hah you read my mind. I think commenting will be a bit too noisy. We can provide a nicer table output in the github actions check format though

rexagod commented 6 months ago

Do you think it'd be fine to keep the bench results implicit? I thought we may want to post them on the PR (and remove older ones when a new one is posted), to make the benchmarks more apparent in a manner that they are never missed.

For the noisy part, I was wondering we could do something like (the click-to-expand element),

KSM Benchmark Output

Details ``` foo ```

I'm neutral on this. LMK if you think we'd be better off without this, and I'll create a PR for improving the format in the CI logs themselves.

mrueg commented 6 months ago

I'm afraid of too much noise if someone force pushes several times. Do you think it would be possible to only comment if benchmarks change let's say more than 5% to the baseline?

logicalhan commented 6 months ago

/triage accepted /assign @rexagod

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 1 month ago

@k8s-triage-robot: Closed this PR.

In response to [this](https://github.com/kubernetes/kube-state-metrics/pull/2273#issuecomment-2106335074): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the PR is closed > >You can: >- Reopen this PR with `/reopen` >- Mark this PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.