search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.21k stars 1.93k forks source link

feat: validate stable metrics via static analysis, which adapts codes from k/k stable metrics framework #2294

Open CatherineF-dev opened 6 months ago

CatherineF-dev commented 6 months ago

What this PR does / why we need it: https://github.com/kubernetes/kube-state-metrics/blob/cee19c38d054a0dac4891d98c43d85949b5498b9/docs/design/validate-stable-metrics.md

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) N/A

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes/kube-state-metrics/issues/1833

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CatherineF-dev Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
CatherineF-dev commented 6 months ago

cc @mrueg, I added static analysis example code in this PR.

dashpole commented 5 months ago

/assign @rexagod /triage accepted

CatherineF-dev commented 5 months ago

Ping~

rexagod commented 5 months ago

Ah! I missed this, thank you for all the great work here! I'll review this ASAP! Sorry for the delay here! :/

CatherineF-dev commented 5 months ago

Ping~

CatherineF-dev commented 4 months ago

Ping~

k8s-ci-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

CatherineF-dev commented 1 week ago

/remove-lifecycle stale

rexagod commented 1 week ago

@CatherineF-dev How about adding this PR to the SIG weekly agenda? Just a high-level introduction of what this does while gathering feedback from the rest of the SIG should make sure we don't miss anything here.

CatherineF-dev commented 1 week ago

@rexagod okay!