search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.21k stars 1.93k forks source link

fix: adjust "volume name" label for kube_persistentvolumeclaim_* #2303

Open multani opened 5 months ago

multani commented 5 months ago

What this PR does / why we need it:

This changes the name of the volume name label, reported by the kube_persistentvolumeclaim_* metrics, to be the same label as the one in the kube_persistentvolume_* metrics.

This makes it easier to combine the 2 related set of metrics together to being labels and values from one metric into another.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Does not change cardinality

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #2288

k8s-ci-robot commented 5 months ago

Welcome @multani!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

multani commented 5 months ago

Sorry for the noise, I was trying to understand what was the problem with the commit message :facepalm:

Should be good now :)

CatherineF-dev commented 5 months ago

Also update https://github.com/kubernetes/kube-state-metrics/blob/main/CHANGELOG.md

Next:

multani commented 5 months ago

Also update https://github.com/kubernetes/kube-state-metrics/blob/main/CHANGELOG.md

Done! :+1:

dgrisonnet commented 5 months ago

/triage accepted /assign @CatherineF-dev @dgrisonnet

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: multani Once this PR has been reviewed and has the lgtm label, please ask for approval from dgrisonnet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mrueg commented 5 months ago

Also update https://github.com/kubernetes/kube-state-metrics/blob/main/CHANGELOG.md

Next:

Has anything changed in the release process I'm not aware of? We usually do not update the changelog within the PR.

k8s-ci-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 13 hours ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale