search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.21k stars 1.93k forks source link

chore: Cut v2.11.0 #2317

Closed rexagod closed 3 months ago

rexagod commented 4 months ago

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Fixes #2293

rexagod commented 4 months ago

v2.12.0+ will be released through an automated workflow, pushing shortly.

krishnaindani commented 4 months ago

Is there any plan to fix https://github.com/advisories/GHSA-5f94-vhjq-rpg8 and https://github.com/advisories/GHSA-vvjp-q62m-2vph CVE's with this release? Fix is to build with 1.21.5 or 1.21.12.

dashpole commented 4 months ago

/assign @dgrisonnet /triage accepted

krishnaindani commented 4 months ago

when is the plan to release this version?

mrueg commented 4 months ago

Can you fix the markdown lint and rebase the release-2.11 branch on main first to reduce the delta to a minimum (that will help with merging it back)? https://github.com/kubernetes/kube-state-metrics/compare/release-2.11...main

mrueg commented 4 months ago

Also I would suggest to wait for tomorrow until go 1.21.8 is released, see: https://groups.google.com/g/golang-announce/c/smSYdsWaO4o

mrueg commented 3 months ago

/lgtm

/hold for @rexagod to unhold.

rexagod commented 3 months ago

@dgrisonnet I believe this is good to go in now, but seeing as https://github.com/kubernetes/kube-state-metrics/pull/2270#issuecomment-1955093046 might be an /lgtm away, can we merge and include that here as well?

rexagod commented 3 months ago

/unhold /lgtm

Will include #2270 in the next release, going forward with this one since this has been in the pipeline for a while.

k8s-ci-robot commented 3 months ago

@rexagod: you cannot LGTM your own PR.

In response to [this](https://github.com/kubernetes/kube-state-metrics/pull/2317#issuecomment-1991201087): >/unhold >/lgtm > >Will include #2270 in the next release, going forward with this one since this has been in the pipeline for a while. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/release-2.11/OWNERS)~~ [mrueg,rexagod] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment