search

kubernetes / kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.
https://kubernetes.io/docs/concepts/cluster-administration/kube-state-metrics/
Apache License 2.0
5.36k stars 2k forks source link

chore: use string verb to format logging messages in tests #2363

Closed ovidiutirla closed 5 months ago

ovidiutirla commented 5 months ago

What this PR does / why we need it: The %w makes the CI to fail, replacing it back to %s. After the https://github.com/kubernetes/kube-state-metrics/pull/2358 was merged, looks like the CI is failing on the main branch.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) no impact

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 5 months ago

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ovidiutirla commented 5 months ago

This verb can be used only in 'fmt.Errorf' calls (%w) which makes the CI to fail on the main branch, see ci-go-lint, ci-benchmark-tests, ci-e2e-tests.

/assign @rexagod

ovidiutirla commented 5 months ago

The ci-benchmark-tests is failing as it's using the code from the main branch. Looks like for some reason on https://github.com/kubernetes/kube-state-metrics/pull/2358 the CI didn't ran.

mrueg commented 5 months ago

/lgtm

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, ovidiutirla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kube-state-metrics/blob/main/OWNERS)~~ [mrueg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mrueg commented 5 months ago

Merging this manually to get CI working :)

rexagod commented 5 months ago

That's my bad, I didn't notice the log.Fatalf call and assumed that to be a fmt.Errorf for some reason (%w is only valid there). 🤦