kubernetes / kubeadm

Aggregator for issues filed against kubeadm
Apache License 2.0
3.76k stars 716 forks source link

NodeSwap feature supports in kubeadm #2563

Open pacoxu opened 3 years ago

pacoxu commented 3 years ago

Is this a BUG REPORT or FEATURE REQUEST?

FEATURE REQUEST

/kind feature

Versions

kubeadm version (use kubeadm version): NodeSwap is alpha in 1.22 and will be beta1 in 1.28(still default disabled).

What happened?

I tested NodeSwap on my nodes and when I re-install my env, I got error related to swap.

    [ERROR Swap]: running with swap on is not supported. Please disable swap

I think it's time to start planning for Swap enabling support on the kubeadm side.

What you expected to happen?

There should be NodeSwap support in kubeadm init and we can skip the check if the feature gate is enabled. Or in 1.23, we should skip the prelight check by default as it will be beta.

How to reproduce it (as minimally and precisely as possible)?

swapon and run kubeadm init

Anything else we need to know?

More details in https://github.com/kubernetes/enhancements/issues/2400

/assign