search

kubernetes / kubeadm

Aggregator for issues filed against kubeadm
Apache License 2.0
3.77k stars 717 forks source link

kubeadm doesn't pass etcd progress notification flag #2731

Open p0lyn0mial opened 2 years ago

p0lyn0mial commented 2 years ago

What happened?

The experimental-watch-progress-notify-interval flag specifies an interval at which etcd sends data to the kube-api server.

It is used by the WatchBookmark feature ( kube-apiserver) which is GA since 1.17. It will also be used by a new WatchList feature (kube-apiserver's) which is Alpha since 1.25

Given the above, a default installation must pass the flag required by the kube-apiserver to etcd. Otherwise, some features will not work.

Note that the feature was graduated to GA (non-experiment) in etcd 3.5 without any code changes. Once kubernetes switches to etcd in 3.5 the flag name will have to be changed.

What did you expect to happen?

The experimental-watch-progress-notify-interval flag is specified on etcd binary.

How can we reproduce it (as minimally and precisely as possible)?

atm the kubeadm does not specify the flag. So simply installing a cluster is enough to reproduce the issue.

Anything else we need to know?

No response

Kubernetes version

```console $ kubectl version # paste output here ``` n/a

Cloud provider

n/a

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

‐---------

edit neolit123

1.25

next

k8s-ci-robot commented 2 years ago

@p0lyn0mial: There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 years ago

@p0lyn0mial: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
p0lyn0mial commented 2 years ago

/cc @neolit123 @aojea

k8s-ci-robot commented 2 years ago

@neolit123: Something went wrong or the destination repo kubernetes/khbeadm does not exist.

In response to [this](https://github.com/kubernetes/kubeadm/issues/2731): >/transfer khbeadm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
neolit123 commented 2 years ago

/transfer kubeadm

neolit123 commented 2 years ago

/kind feature /remove-kind bug

wojtek-t commented 2 years ago

FWIW - I'm copying my comment from the original issue to give a context:

  1. The feature was graduated to GA (non-experiment) in etcd 3.5 without any code changes so I think we're fine.

  2. We already enabled that for all GCE tests long time ago: https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/config-test.sh#L578 https://github.com/kubernetes/kubernetes/blob/8415ae647d2c433c89910a0e677094e3a20ffb2b/cluster/gce/gci/configure-helper.sh#L1851

  3. We're heavily relying on this setting for efficient watch resumption KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1904-efficient-watch-resumption/README.md#proposal [which is already GA]

  4. FWIW - we enabled that setting in GKE (together with etcd 3.4) quite some time ago

So I don't consider this an experimental feature. The problem is that there weren't any etcd release after 3.4 for ~2 years, and 3.5 that was released last year is still not fully production ready (not qualified enough).

So I personally think that we are now ready to just enable it in kind for everyone, but I'm not kind maintainer so it needs to be decided by kind maintainers.

pacoxu commented 1 year ago

Link the etcd issue for graduating this flag: https://github.com/etcd-io/etcd/issues/13779

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pacoxu commented 1 year ago

/remove-lifecycle stale

pacoxu commented 1 year ago

This is in the plan of etcd v3.6. Move it to v1.29 then.

liangyuanpeng commented 10 months ago

/sig etcd

IMO

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 3 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale