search

kubernetes / kubeadm

Aggregator for issues filed against kubeadm
Apache License 2.0
3.74k stars 712 forks source link

cleanup docs post GCS infra migration #2876

Open neolit123 opened 1 year ago

neolit123 commented 1 year ago

see this and linked tracked issues:

the k/kubeadm docs contain some outdated examples. the PR above fixes some of them, but there is remaining work.

note we cannot change gs://k8s-release-dev/ci/ yet: https://github.com/kubernetes/kubeadm/pull/2872#discussion_r1193581291

so this issue tracks future work. but the /cluster change can be PRed now.

pacoxu commented 1 year ago

/assign @rjsadow

chendave commented 1 year ago

Just a record, here is still reference to gcs bucket, https://github.com/kubernetes/kubeadm/blob/3d02f6cd3ac64a9446bece239588291ec12cdad2/docs/testing-pre-releases.md?plain=1#L117-L119

Is there any alternative to replace it? https://console.cloud.google.com/storage/browser/kubernetes-release/release/

When we have any other options, we can update the link above.

chendave commented 1 year ago

remove / change all gs:// entries in docs

@neolit123 what do you mean for this todo item? I searched in the code base, seems this has been addressed unless the gs://k8s-release-dev/ci/ (I understood this will stay for an while).

neolit123 commented 1 year ago

Is there any alternative to replace it?

@rjsadow do you know if we can list these labels with curl?

neolit123 commented 1 year ago

remove / change all gs:// entries in docs

@neolit123 what do you mean for this todo item? I searched in the code base, seems this has been addressed unless the gs://k8s-release-dev/ci/ (I understood this will stay for an while).

we can't change it for now, afaik. it was discussed earlier as planned.

rjsadow commented 1 year ago

I don't believe there's a direct 1-for-1 replacement with curl in this case since directory browsing isn't available through the proxy. It might be worth reaching out to sig-release and seeing if we could add an index file or some other mechanism into the release bucket that provides a list of all latest and stable versions.

neolit123 commented 1 year ago

i think we can just remove this sentence, as the prev one already includes the most relevant labels

See https://console.cloud.google.com/storage/browser/kubernetes-release/release/ for the full list of labels.

rjsadow commented 1 year ago

Let me take a crack at rewording it. The problem with removing it and referencing the release page is that only includes GA versions. If someone wants to test with a pre-release version they really should reference these files to get the tags to use.

i.e.

❯ curl -L https://dl.k8s.io/release/latest-1.txt
v1.28.0-alpha.2

Which is the tag that should be used for the images. I don't know any better way to point someone to pre-release image tags.

neolit123 commented 1 year ago

Which is the tag that should be used for the images. I don't know any better way to point someone to pre-release image tags.

i don't know either for pre built ci images. in kubeadm e2e tests we build images from tars for a particular k/k commit. those tars are for sure available in the current ci bucket.

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten