[failing test] kubeadm-kinder-control-plane-kubelet-local-mode-latest "upgrade diff" action failing

[neolit123]

after the recent changes for upgrade phases, the https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-control-plane-kubelet-local-mode-latest test continue to be red.

the failure seems to be

kinder-control-plane-local-kubelet-mode-control-plane-1:$ kubeadm upgrade diff --v=6 --config /kind/kubeadm.conf
time="08:08:14" level=debug msg="Running: docker exec kinder-control-plane-local-kubelet-mode-control-plane-1 kubeadm upgrade diff --v=6 --config /kind/kubeadm.conf"
empty manifest path
k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade.validateManifestsPath
    k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade/diff.go:92
k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade.newCmdDiff.func1
    k8s.io/kubernetes/cmd/kubeadm/app/cmd/upgrade/diff.go:69
github.com/spf13/cobra.(*Command).execute
    github.com/spf13/cobra@v1.8.1/command.go:985
github.com/spf13/cobra.(*Command).ExecuteC
    github.com/spf13/cobra@v1.8.1/command.go:1117
github.com/spf13/cobra.(*Command).Execute
    github.com/spf13/cobra@v1.8.1/command.go:1041
k8s.io/kubernetes/cmd/kubeadm/app.Run
    k8s.io/kubernetes/cmd/kubeadm/app/kubeadm.go:47
main.main
    k8s.io/kubernetes/cmd/kubeadm/kubeadm.go:25
runtime.main
    runtime/proc.go:272
runtime.goexit
    runtime/asm_amd64.s:1700
Error: failed to exec action kubeadm-upgrade: exit status 1
 exit status 1

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-kinder-control-plane-kubelet-local-mode-latest/1834140259051376640/build-log.txt

[neolit123]

i think this might be due to https://github.com/kubernetes/kubernetes/commit/d62b797c16fdffa55a8e2fc95f04bf72c019be70

[SataQiu]

Yes, we should also update here.

    if err := validateManifestsPath(
        flags.apiServerManifestPath,
        flags.controllerManagerManifestPath,
        flags.schedulerManifestPath); err != nil {
        return err
    }

https://github.com/kubernetes/kubernetes/blob/d589a3f866144087e19d092a63b2ef275f2ab912/cmd/kubeadm/app/cmd/upgrade/diff.go#L70-L73

[neolit123]

/assign will send PR soon

[neolit123]

fix is here

• https://github.com/kubernetes/kubernetes/pull/127315

tested it locally