search

kubernetes / kubectl

Issue tracker and mirror of kubectl code
Apache License 2.0
2.75k stars 894 forks source link

add `imagePullSecrets` for `debug` command #1567

Closed warjiang closed 4 months ago

warjiang commented 4 months ago

What would you like to be added: add imagePullSecrets for debug like 

kubectl debug node/mynode -it --image=busybox --image-pull-secrets=myRegistryKeySecretName1 --image-pull-secrets=myRegistryKeySecretName2

Why is this needed: in case of enterprise, private registry is the first choice, if execute kubectl debug node/mynode -it --image=${registry}/busybox it will report image pull error, so we need add imagePullSecrets options.

k8s-ci-robot commented 4 months ago

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ardaguclu commented 4 months ago

I think, this will be handled by this feature https://github.com/kubernetes/enhancements/issues/4292.

ardaguclu commented 4 months ago

and this is the duplicate of https://github.com/kubernetes/kubectl/issues/1506

warjiang commented 4 months ago

and this is the duplicate of #1506

yes! it's exactly what I wanted

warjiang commented 4 months ago

I think, this will be handled by this feature kubernetes/enhancements#4292.

em, new to kubernetes community, and how, it's not a breaking change, maybe you can copy the copy or just cherry-pick the commit, anyway is ok for me 😃

warjiang commented 4 months ago

I think, this will be handled by this feature kubernetes/enhancements#4292.

@ardaguclu hi~ I'm new to kubernetes community, what should I do to make this change into KEP4292, making comments in https://github.com/kubernetes/enhancements/issues/4292 ? any suggestions or advices 😃

ardaguclu commented 4 months ago

@warjiang thanks for your enthusiasm. You'll get this feature for free, when this PR https://github.com/kubernetes/kubernetes/pull/120346 merges.

ardaguclu commented 4 months ago

I'm closing this as it has already been marked as duplicate. /close

k8s-ci-robot commented 4 months ago

@ardaguclu: Closing this issue.

In response to [this](https://github.com/kubernetes/kubectl/issues/1567#issuecomment-1978747545): >I'm closing this as it has already been marked as duplicate. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
warjiang commented 3 months ago

I'm closing this as it has already been marked as duplicate. /close

ok. i'll close this pr in main repo of kubernetes https://github.com/kubernetes/kubernetes/pull/123581

thanks for your reply as well 😄