search

kubernetes / kubectl

Issue tracker and mirror of kubectl code
Apache License 2.0
2.75k stars 894 forks source link

Update kustomize to a version that supports oci repos #1572

Closed Griznah closed 5 days ago

Griznah commented 3 months ago

What would you like to be added: A current version of kustomize, ie. https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.3.0 Why is this needed: To use built in kustomize with OCI helm repos as added in https://github.com/kubernetes-sigs/kustomize/pull/5167

lucsoft commented 3 months ago

Took me a while to find out that my newest version of kubectl doesn't ship with the newest version of kustomize? Tried to debug why oci helm charts arent working... now i found the issue. Why does kubectl not just use the latest version of kustomize?

lucsoft commented 3 months ago

Current main has pinned a version for over 10 months, thats crazy :D image

eddiezane commented 3 months ago

@koba1t how do you want to handle bumping kustomize in kubectl going forward?

koba1t commented 3 months ago

@eddiezane I plan to kustomize maintainer update kustomize in kubectl when we release a new version. I think it means we keep the current flow.

We haven't created a new release of Kustomize recently because we are still a bit confused by the change in the lead. I plan to create a new release next week and use it to update the kustomize pkg in kubectl.

koba1t commented 2 months ago

I created a PR that updates kustomize-in-kubectl. https://github.com/kubernetes/kubernetes/pull/124217

ardaguclu commented 5 days ago

I believe that this is completed;

/close

k8s-ci-robot commented 5 days ago

@ardaguclu: Closing this issue.

In response to [this](https://github.com/kubernetes/kubectl/issues/1572#issuecomment-2196836030): >I believe that this is completed; > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
koba1t commented 5 days ago

FYI, Another PR that updated kustomize in kubectl was merged. https://github.com/kubernetes/kubernetes/pull/123339/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R222-R224