kubernetes / kubectl

Issue tracker and mirror of kubectl code
Apache License 2.0
2.75k stars 894 forks source link

Improve tests for container-name autocompletion for exec commands #1600

Closed TessaIO closed 1 month ago

TessaIO commented 1 month ago

What would you like to be added?

Tests in container-name autocompletion are done in separate functions and they don't cover the actual functionality which is auto-completing the container-name. We can compact those methods in a test table and add more tests to cover more cases.

Why is this needed?

This is needed to improve the confidence in these tests and make them more maintainable and clean.

k8s-ci-robot commented 1 month ago

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
TessaIO commented 1 month ago

/assign

TessaIO commented 1 month ago

/sig cli

TessaIO commented 1 month ago

/transfer kubectl