node_e2e: Cleanup configuration and rename jenkins/ directory

endocrimes commented 3 years ago

/kind cleanup /sig node /area test /priority important-longterm /assign

Currently, node_e2e configuration exists in the jenkins/ directory underneath node_e2e. This directory is a hangover from the time before Kubernetes migrated to Prow. This directory is regularly a point of contention when adding new features to tests, and causes confusion to people trying to make changes to them.

We should remove the unused portions of this directory and rename it to something more useful (e2e_node/configuration?) to simplify future changes while maintaining the current developer workflow.

This is going to involve coordinating a couple of things between k/k and k/test-infra to ensure that we do not cause a break in tests during the migration process and to not break running tests against older release branches.

My naive suggestion for handling this would be:

[ ] Remove unused code from jenkins/
[ ] Create a copy of the jenkins/ directory with the new name
[ ] Update test-infra to reference the new paths, duplicating configurations where necessary to preserve jobs for older branches
[ ] Remove the jenkins/ directory

(@spiffxp / @dims might have better suggestions for how to handle this?)

SergeyKanzhelev commented 3 years ago

There is an old issue for this and the PR: https://github.com/kubernetes/kubernetes/pull/99606

We can keep either. I like the checkboxes in this issue

endocrimes commented 3 years ago

Oh I missed the issue reference and github-search-foo failed me - fine with either 😅

SergeyKanzhelev commented 3 years ago

cleaned up duplicates

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

endocrimes commented 2 years ago

/remove lifecycle state /lifecycle frozen

mmiranda96 commented 1 year ago

@endocrimes are you still working on this? If not, you can unassign yourself so someone else can take it.

SergeyKanzhelev commented 10 months ago

/unassign @endocrimes

AnishShah commented 2 months ago

/triage accepted

AnishShah commented 2 months ago

/cc @AnishShah

kubernetes / kubernetes

node_e2e: Cleanup configuration and rename jenkins/ directory #106119