kubernetes / kubernetes

Production-Grade Container Scheduling and Management
https://kubernetes.io
Apache License 2.0
107.92k stars 38.76k forks source link

Passing CDI devices as annotations should be removed #125210

Open bart0sh opened 2 weeks ago

bart0sh commented 2 weeks ago

Kubelet should stop using annotations to pass CDI device IDs to CRI runtimes. CDIDevices CRI field should be used for this purpose.

This should be done when Kubelet that doesn't support CRI field reaches EOL and two major CRI runtimes support CRI field.

Here is a PR comment that gives more details about this: https://github.com/kubernetes/kubernetes/pull/115891/files#r1112169121

So, safer option would be to wait until Containerd 1.7 reaches EOL. However it's relatively safe to do it earlier when 1.7.0 and 1.7.1 have little chances to be in real use.

Containerd v1.7.0 and v1.7.1 is not used by the Linux distributions from this long list, so it's safe to remove annotations support from the Kubelet in 1.31 in my opinion.

bart0sh commented 2 weeks ago

/sig node

ffromani commented 2 weeks ago

/triage accepted /priority important-longterm

bart0sh commented 2 weeks ago

/assign