search

kubernetes / kubernetes

Production-Grade Container Scheduling and Management
https://kubernetes.io
Apache License 2.0
111.51k stars 39.77k forks source link

s390x support for agnhost and nonewprivs #97318

Closed rajaskakodkar closed 3 years ago

rajaskakodkar commented 3 years ago

s390x support for nonewprivs image was added in #94876 and the commit from #94875 was cherry picked in #95032 to fix agnhost broken on s390x. However, the post merge job post-kubernetes-push-e2e-test-images failed for both(https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-e2e-test-images/1309411632278933504 https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-e2e-test-images/1324809920880578560) as image builder was broken.

Now that image builder has been fixed in #96462, these jobs need to be restarted to push s390x tags of agnhost and nonewprivs in staging bucket.

cc @dims

k8s-ci-robot commented 3 years ago

@rajaskakodkar: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rajaskakodkar commented 3 years ago

/sig testing

dims commented 3 years ago

@chaodaig as you are on call this week, can you please run the CI job mentioned by hand?

chaodaiG commented 3 years ago

@dims , when I try to run the job with bazel run //prow/cmd/mkpj -- --job=post-kubernetes-push-e2e-test-images --config-path=$(PWD)/config/prow/config.yaml --job-config-path=$(PWD)/config/jobs, it failed with FATA[0000] Job post-kubernetes-push-e2e-test-images not found..

So I went over and looked at the history and found that this job was deleted by https://github.com/kubernetes/test-infra/pull/19924 on 11/11.

I don't think prow allows running a job that doesn't exist in its configmap, and searching the prow history with gsutil ls gs://kubernetes-jenkins/logs | grep post-kubernetes-push-e2e- got:

gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-agnhost-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-pets-redis-installer-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-pets-zookeeper-installer-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-resource-consumer-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-sample-apiserver-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-volume-gluster-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-volume-iscsi-test-images/
gs://kubernetes-jenkins/logs/post-kubernetes-push-e2e-volume-nfs-test-images/

This is the list of jobs that have ever ran since prow keeps all history in GCS, which indicates that not all of the new jobs added in https://github.com/kubernetes/test-infra/pull/19924 has ran yet, can you take a look at https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/k8s-staging-e2e-test-images.yaml and let us know which job is that you want?

dims commented 3 years ago

@chaodaiG thanks for looking. let's ask @claudiubelu what jobs need to be triggered.

claudiubelu commented 3 years ago

Hello,

The post-kubernetes-push-e2e-test-images has been split into individual jobs for individual images and are now triggered by changes made in that image's folder. The jobs haven't been run yet since the split. You can trigger a job by sending a PR (e.g.: bumping the VERSION) and getting it merged.

chewong commented 3 years ago

/reopen Still failing according https://testgrid.k8s.io/sig-testing-images#post-kubernetes-push-e2e-agnhost-test-images. #97938 should fix it.

k8s-ci-robot commented 3 years ago

@chewong: Reopened this issue.

In response to [this](https://github.com/kubernetes/kubernetes/issues/97318#issuecomment-758315294): >/reopen >Still failing according https://testgrid.k8s.io/sig-testing-images#post-kubernetes-push-e2e-agnhost-test-images. #97938 should fix it. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rajaskakodkar commented 3 years ago

/close @chewong I am closing this issue as the agnhost job passed https://testgrid.k8s.io/sig-testing-images#post-kubernetes-push-e2e-agnhost-test-images and the multiarch image is now available, it works fine for s390x as conformance job passed with the same https://testgrid.k8s.io/conformance-s390x#Periodic%20s390x%20conformance%20test%20on%20local%20cluster

k8s-ci-robot commented 3 years ago

@rajaskakodkar: Closing this issue.

In response to [this](https://github.com/kubernetes/kubernetes/issues/97318#issuecomment-762229791): >/close >@chewong I am closing this issue as the agnhost job passed https://testgrid.k8s.io/sig-testing-images#post-kubernetes-push-e2e-agnhost-test-images and the multiarch image is now available, it works fine for s390x as conformance job passed with the same https://testgrid.k8s.io/conformance-s390x#Periodic%20s390x%20conformance%20test%20on%20local%20cluster Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.