search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.28k stars 4.87k forks source link

NGINX configmap/ingress-nginx-controller reset on every startup #13755

Open logopk opened 2 years ago

logopk commented 2 years ago

What Happened?

My SSL Hardening settings are reset on every startup of minikube to hsts: "false" .

I have tried to add my personal addon to ~/.minikube/addons/ingress-deploy.yaml (16490 bytes). the file is copied via ssh to the server, but upon deployment it is taken from "memory" (whatever that is) and reset to the tmpl-Version from the github repo https://github.com/kubernetes/minikube/blob/master/deploy/addons/ingress/ingress-deploy.yaml.tmpl

I0307 18:07:29.955380   94826 filesync.go:126] Scanning /Users/logo/.minikube/addons for local assets ...
I0307 18:07:29.955727   94826 filesync.go:149] local asset: /Users/logo/.minikube/addons/ingress-deploy.yaml -> ingress-deploy.yaml in /etc/kubernetes/addons
I0307 18:07:29.955770   94826 vm_assets.go:163] NewFileAsset: /Users/logo/.minikube/addons/ingress-deploy.yaml -> /etc/kubernetes/addons/ingress-deploy.yaml
I0307 18:07:29.960826   94826 ssh_runner.go:195] Run: stat -c "%!s(MISSING) %!y(MISSING)" /etc/kubernetes/addons/ingress-deploy.yaml
I0307 18:07:29.962633   94826 ssh_runner.go:352] existence check for /etc/kubernetes/addons/ingress-deploy.yaml: source file and destination file are different sizes
I0307 18:07:29.962695   94826 ssh_runner.go:362] scp /Users/logo/.minikube/addons/ingress-deploy.yaml --> /etc/kubernetes/addons/ingress-deploy.yaml (16490 bytes)
...
I0307 18:07:56.320757   94826 addons.go:348] installing /etc/kubernetes/addons/ingress-deploy.yaml
I0307 18:07:56.320800   94826 ssh_runner.go:362] scp memory --> /etc/kubernetes/addons/ingress-deploy.yaml (15567 bytes)
...
I0307 18:07:56.475502   94826 ssh_runner.go:195] Run: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.23.3/kubectl apply -f /etc/kubernetes/addons/ingress-deploy.yaml

Thank you for helping.

BTW: kubernetes docs say that hsts: "true" is the default, where as the template set it to hsts: "false" and no other defaults.

Attach the log file

▶ minikube start --driver=ssh --ssh-ip-address=xxx --ssh-user=root --ssh-key=/Users/logo/.ssh/minikube_ed25519 --native-ssh=false --alsologtostderr -v=5 2> start.log

I0307 18:07:29.955380   94826 filesync.go:126] Scanning /Users/logo/.minikube/addons for local assets ...
I0307 18:07:29.955727   94826 filesync.go:149] local asset: /Users/logo/.minikube/addons/ingress-deploy.yaml -> ingress-deploy.yaml in /etc/kubernetes/addons
I0307 18:07:29.955770   94826 vm_assets.go:163] NewFileAsset: /Users/logo/.minikube/addons/ingress-deploy.yaml -> /etc/kubernetes/addons/ingress-deploy.yaml
I0307 18:07:29.960826   94826 ssh_runner.go:195] Run: stat -c "%!s(MISSING) %!y(MISSING)" /etc/kubernetes/addons/ingress-deploy.yaml
I0307 18:07:29.962633   94826 ssh_runner.go:352] existence check for /etc/kubernetes/addons/ingress-deploy.yaml: source file and destination file are different sizes
I0307 18:07:29.962695   94826 ssh_runner.go:362] scp /Users/logo/.minikube/addons/ingress-deploy.yaml --> /etc/kubernetes/addons/ingress-deploy.yaml (16490 bytes)
...
I0307 18:07:56.320757   94826 addons.go:348] installing /etc/kubernetes/addons/ingress-deploy.yaml
I0307 18:07:56.320800   94826 ssh_runner.go:362] scp memory --> /etc/kubernetes/addons/ingress-deploy.yaml (15567 bytes)
...
I0307 18:07:56.475502   94826 ssh_runner.go:195] Run: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.23.3/kubectl apply -f /etc/kubernetes/addons/ingress-deploy.yaml

Operating System

macOS (Default)

Driver

SSH

RA489 commented 2 years ago

/kind support

sharifelgamal commented 2 years ago

Yeah this has to do with how addons work. On restart, we reapply the default tempate yamls for the ingress addon, which will indeed wipe out any changes you've made.

The solution here could be to add an entry to minikube addons configure so that we can accept non-default config.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

RA489 commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

logopk commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

logopk commented 1 year ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-1453064521): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
logopk commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@logopk: Reopened this issue.

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-1453185490): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-1493277076): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
logopk commented 1 year ago

please /reopen - this is a hassle.

logopk commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@logopk: Reopened this issue.

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-1506932677): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-1546657714): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
logopk commented 1 year ago

/remove-lifecycle rotten

logopk commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@logopk: Reopened this issue.

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-1546660493): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

logopk commented 8 months ago

/reopen

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

logopk commented 7 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 6 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-2009402426): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
logopk commented 6 months ago

/remove-lifecycle rotten

logopk commented 6 months ago

/reopen

k8s-ci-robot commented 6 months ago

@logopk: Reopened this issue.

In response to [this](https://github.com/kubernetes/minikube/issues/13755#issuecomment-2010898022): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

logopk commented 3 months ago

/reopen

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

logopk commented 2 months ago

/remove-lifecycle rotten