Open schwichtgit opened 2 years ago
would you accept a PR with this patch to address this?
diff -Naur 1/pkg/minikube/registry/drvs/qemu2/qemu2.go 2/pkg/minikube/registry/drvs/qemu2/qemu2.go
--- 1/pkg/minikube/registry/drvs/qemu2/qemu2.go 2022-09-26 15:25:12.469383191 -0400
+++ 2/pkg/minikube/registry/drvs/qemu2/qemu2.go 2022-09-26 15:48:06.561167788 -0400
@@ -116,7 +116,7 @@
if err != nil {
return semver.Version{}, err
}
- v := strings.Split(strings.TrimPrefix(string(rr), "QEMU emulator version "), "\n")[0]
+ v := strings.Fields(strings.Split(strings.TrimPrefix(string(rr), "QEMU emulator version "), "\n")[0])[0]
return semver.Make(v)
}
would you accept a PR with this patch to address this?
Hi @schwichtgit, yes, feel free to make a PR and we can get this fixed. My recommendation is to remove strings.Split
as it's redundant now that you're grabbing the first value of strings.Fields
.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
I have (finally) filed PR18229
What Happened?
If one builds qemu locally for example on MacOS,
qemu has additional output that trips the minikube qemu driver version parser.
for example
leads to
Operating System
macOS (Default)
Driver
qemu2