kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.17k stars 4.87k forks source link

Addon specific messages not output with `--addons` flag #15277

Closed spowelljr closed 2 weeks ago

spowelljr commented 1 year ago

We have custom messaging to inform the user when enabling specific addons using minikube addons enable <addon>

For example:

$ minikube start
...
$ minikube addons enable ambassador
❗  The ambassador addon has stopped working as of v1.23.0, for more details visit: https://github.com/datawire/ambassador-operator/issues/73
...

But when passing the addon on start with the --addons flag, the message is not output.

For example:

$ minikube start --addons ambassador
😄  minikube v1.27.1 on Darwin 12.6.1 (arm64)
✨  Automatically selected the docker driver. Other choices: ssh, qemu2 (experimental)
📌  Using Docker Desktop driver with root privileges
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=1988MB) .../
🐳  Preparing Kubernetes v1.25.3 on Docker 20.10.20 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image quay.io/datawire/ambassador-operator:v1.2.3
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
Aut0R3V commented 1 year ago

Hey @spowelljr if you could tell me how to achieve this, I'm ready to work on this.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

spowelljr commented 2 weeks ago

This has been implemented

$ ./out/minikube start --addons ambassador
😄  minikube v1.33.1 on Darwin 14.6.1 (arm64)
✨  Automatically selected the docker driver. Other choices: qemu2, ssh, podman (experimental)
📌  Using Docker Desktop driver with root privileges
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🚜  Pulling base image v0.0.44-1724775115-19521 ...
    > gcr.io/k8s-minikube/kicbase...:  441.40 MiB / 441.40 MiB  100.00% 12.28 M
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.31.0 on Docker 27.1.2 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
❗  The ambassador addon has stopped working as of v1.23.0, for more details visit: https://github.com/datawire/ambassador-operator/issues/73
    ▪ Using image quay.io/datawire/ambassador-operator:v1.2.3
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5