kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.36k stars 4.88k forks source link

implement "detailed" addon list for -o=json #15862

Closed medyagh closed 1 year ago

medyagh commented 1 year ago

minikube addon list has a flag called -d that will show extra information

$ minikube addons list  -d
|-----------------------------|----------|--------------|--------------------------------|-----------------------------------------------------------------------------------|
|         ADDON NAME          | PROFILE  |    STATUS    |           MAINTAINER           |                                       DOCS                                        |
|-----------------------------|----------|--------------|--------------------------------|-----------------------------------------------------------------------------------|
| ambassador                  | minikube | disabled     | 3rd party (Ambassador)         | https://minikube.sigs.k8s.io/docs/tutorials/ambassador_ingress_controller/        |
| auto-pause                  | minikube | disabled     | Google                         | n/a                                                                               |
| cloud-spanner               | minikube | disabled     | Google                         | https://minikube.sigs.k8s.io/docs/handbook/addons/cloud-spanner/                  |
| csi-hostpath-driver         | minikube | disabled     | Kubernetes                     | https://minikube.sigs.k8s.io/docs/tutorials/volume_snapshots_and_csi/             |
| dashboard                   | minikube | disabled     | Kubernetes                     | https://minikube.sigs.k8s.io/docs/handbook/dashboard/                             |
| default-storageclass        | minikube | enabled ✅   | Kubernetes                     | https://minikube.sigs.k8s.io/docs/handbook/persistent_volumes/                    |
| efk                         | minikube | disabled     | 3rd party (Elastic)            | n/a                                                                               |
| freshpod                    | minikube | disabled     | Google                         | https://github.com/GoogleCloudPlatform/freshpod                                   |
| gcp-auth                    | minikube | disabled     | Google                         | https://minikube.sigs.k8s.io/docs/handbook/addons/gcp-auth/                       |

but this information is not implemented in the json format of the command

$ minikube addons list -o=json -d
{"ambassador":{"Profile":"minikube","Status":"disabled"},"auto-pause":{"Profile":"minikube","Status":"disabled"},"cloud-spanner":{"Profile":"minikube","Status":"disabled"},"csi-hostpath-driver":{"Profile":"minikube","Status":"disabled"},"dashboard":{"Profile":"minikube","Status":"disabled"},"default-storageclass":{"Profile":"minikube","Status":"enabled"},"efk":{"Profile":"minikube","Status":"disabled"},"freshpod":{"Profile":"minikube","Status":"disabled"},"gcp-auth":{"Profile":"minikube","Status":"disabled"},"gvisor":{"Profile":"minikube","Status":"disabled"},"headlamp":{"Profile":"minikube","Status":"disabled"},"helm-tiller":{"Profile":"minikube","Status":"disabled"},"inaccel":{"Profile":"minikube","Status":"disabled"},"ingress":{"Profile":"minikube","Status":"disabled"},"ingress-dns":{"Profile":"minikube","Status":"disabled"},"istio":{"Profile":"minikube","Status":"disabled"},"istio-provisioner":{"Profile":"minikube","Status":"disabled"},"kong":{"Profile":"minikube","Status":"disabled"},"kubevirt":{"Profile":"minikube","Status":"disabled"},"logviewer":{"Profile":"minikube","Status":"disabled"},"metallb":{"Profile":"minikube","Status":"disabled"},"metrics-server":{"Profile":"minikube","Status":"disabled"},"nvidia-driver-installer":{"Profile":"minikube","Status":"disabled"},"nvidia-gpu-device-plugin":{"Profile":"minikube","Status":"disabled"},"olm":{"Profile":"minikube","Status":"disabled"},"pod-security-policy":{"Profile":"minikube","Status":"disabled"},"portainer":{"Profile":"minikube","Status":"disabled"},"registry":{"Profile":"minikube","Status":"disabled"},"registry-aliases":{"Profile":"minikube","Status":"disabled"},"registry-creds":{"Profile":"minikube","Status":"disabled"},"storage-provisioner":{"Profile":"minikube","Status":"enabled"},"storage-provisioner-gluster":{"Profile":"minikube","Status":"disabled"},"volumesnapshots":{"Profile":"minikube","Status":"disabled"}}
XDRAGON2002 commented 1 year ago

/assign

swastik959 commented 1 year ago

@medyagh hi sorry for not assigning myself this issue but I have submitted a pr can you please review it