search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.5k stars 4.89k forks source link

Addon nvidia-device-plugin: Update nvidia/k8s-device-plugin image from v0.16.0 to v0.16.1 #19336

Closed minikube-bot closed 3 months ago

minikube-bot commented 3 months ago

The k8s-device-plugin project released a new k8s-device-plugin image

This PR was auto-generated by make update-nvidia-device-plugin-version using update-nvidia-device-plugin-version.yml CI Workflow.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 months ago

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
minikube-pr-bot commented 3 months ago

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 19336) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 48.8s    | 71.9s ⚠️             |
| enable ingress    | 25.7s    | 24.6s               |
+-------------------+----------+---------------------+
Times for minikube start: 49.4s 46.2s 47.6s 51.5s 49.6s Times for minikube (PR 19336) start: 50.1s 161.2s 49.6s 50.6s 48.1s Times for minikube ingress: 23.9s 23.9s 23.9s 27.9s 28.9s Times for minikube (PR 19336) ingress: 26.5s 25.4s 23.5s 23.9s 24.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19336) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 24.1s               |
| enable ingress | 21.8s    | 21.8s               |
+----------------+----------+---------------------+
Times for minikube ingress: 21.7s 21.7s 22.2s 21.8s 21.8s Times for minikube (PR 19336) ingress: 21.7s 22.2s 21.3s 21.8s 21.8s Times for minikube start: 23.2s 23.7s 21.6s 23.9s 23.6s Times for minikube (PR 19336) start: 24.0s 24.4s 24.7s 23.6s 23.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19336) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 22.1s               |
| enable ingress | 41.8s    | 42.6s               |
+----------------+----------+---------------------+
Times for minikube start: 22.3s 19.8s 19.5s 23.1s 23.5s Times for minikube (PR 19336) start: 22.1s 19.2s 22.7s 23.0s 23.3s Times for minikube ingress: 41.2s 48.2s 32.2s 48.2s 39.3s Times for minikube (PR 19336) ingress: 47.7s 38.2s 47.2s 31.7s 48.2s
minikube-pr-bot commented 3 months ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Hyperkit_macOS (10 failed) TestStartStop/group/embed-certs/serial/FirstStart(gopogh) 8.41% (chart)
Docker_Linux_docker_arm64 (1 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 6.79% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.