kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.5k stars 4.89k forks source link

add -d shorthand for --driver #19356

Closed medyagh closed 3 months ago

medyagh commented 3 months ago

before this PR

$ mk start -d docker -p d1 
Error: unknown shorthand flag: 'd' in -d
See 'minikube start --help' for usage.

after this PR

$ mk start -d docker -p d1 
😄  [d1] minikube v1.33.1 on Darwin 14.6 (arm64)
✨  Using the docker driver based on user configuration
📌  Using Docker Desktop driver with root privileges
👍  Starting "d1" primary control-plane node in "d1" cluster
🚜  Pulling base image v0.0.44-1721902582-19326 ...
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.30.3 on Docker 27.1.1 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "d1" cluster and "default" namespace by default
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [medyagh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
medyagh commented 3 months ago

/ok-to-test

minikube-pr-bot commented 3 months ago

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19356) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 48.5s               |
| enable ingress | 24.7s    | 25.1s               |
+----------------+----------+---------------------+
Times for minikube start: 50.6s 47.6s 48.0s 46.1s 46.8s Times for minikube (PR 19356) start: 50.1s 50.3s 46.6s 46.9s 48.5s Times for minikube ingress: 23.9s 27.0s 25.4s 23.0s 24.0s Times for minikube (PR 19356) ingress: 27.5s 24.0s 23.5s 25.5s 25.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19356) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 23.5s               |
| enable ingress | 22.0s    | 21.7s               |
+----------------+----------+---------------------+
Times for minikube ingress: 21.3s 23.8s 21.8s 21.8s 21.3s Times for minikube (PR 19356) ingress: 21.3s 21.8s 21.3s 22.8s 21.3s Times for minikube start: 21.8s 20.7s 20.8s 22.0s 25.1s Times for minikube (PR 19356) start: 20.9s 23.9s 24.4s 24.1s 24.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19356) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 22.1s               |
| enable ingress | 51.5s    | 38.1s               |
+----------------+----------+---------------------+
Times for minikube start: 19.7s 24.2s 20.3s 20.3s 23.4s Times for minikube (PR 19356) start: 23.7s 20.3s 20.4s 23.0s 23.0s Times for minikube ingress: 41.3s 48.3s 39.3s 79.3s 49.3s Times for minikube (PR 19356) ingress: 47.3s 31.8s 31.8s 47.8s 31.8s
minikube-pr-bot commented 3 months ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_containerd_arm64 (2 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 46.95% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.