search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.24k stars 4.87k forks source link

site: add docker.io to all echo-server examples #19395

Open medyagh opened 1 month ago

medyagh commented 1 month ago

on crio not specifying the FQDN for the image name makes crio not be able to pull the image, so better to have it FQDN everywhere.

on crio

fails

$ kubectl create deployment hello-minikube --image=kicbase/echo-server:1.0 deployment.apps/hello-minikube created

default       hello-minikube-5c898d8489-8gh5t    0/1     ImageInspectError   0          15s
Failed to inspect image "kicbase/echo-server:1.0": rpc error: code = Unknown desc = short-name "kicbase/echo-server:1.0" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"

works

$ kubectl create deployment hello-minikube2 --image=docker.io/kicbase/echo-server:1.0 deployment.apps/hello-minikube2 created

future works

we should consider adding docker.io to /etc/containers/registries.conf so other people dont have the same issue

https://github.com/kubernetes/minikube/issues/19396

afbjorklund commented 1 month ago

Sounds like a broken cri-o configuration

https://github.com/cri-o/packaging/blob/main/templates/latest/cri-o/bundle/registries.conf

/etc/containers/registries.conf.d/crio.conf

unqualified-search-registries = ["docker.io", "quay.io"]
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [medyagh,spowelljr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment