Closed asusikai closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: asusikai Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Welcome @asusikai!
It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/minikube has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @asusikai. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Can one of the admins verify this patch?
@asusikai this would require building a new docker image for the storage provisioner, do you mind trying it out first and see if it fixes the issue ? you could change the code to point the new storage provisioner image
After checking again, I realized I made a mistake. The directory is created in the form of /tmp/hostpath-provisioner/{namespace}/{service-name}
, and even if I change the umask or modify the group of the parent path to docker, the subdirectories continue to be created with 755 permissions. It seems that I'll need to find another way to fix this.
ok sounds good, please consider closing this PR if not needed anymore
This might resolve CrashLoopBackoff when helm chart tries to use default pv made by minikube. fixes https://github.com/kubernetes/minikube/issues/19481