search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.5k stars 4.89k forks source link

Remove crio-wipe service that is not required #19511

Closed afbjorklund closed 2 months ago

afbjorklund commented 2 months ago

https://github.com/cri-o/cri-o/pull/3545/commits/086982d6184f73681999828905b5a422a92f7024

Closes #18025

afbjorklund commented 2 months ago

/ok-to-build-image

minikube-bot commented 2 months ago

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

spowelljr commented 2 months ago

ok-to-build-iso

afbjorklund commented 2 months ago

Thanks, used the wrong command

minikube-bot commented 2 months ago

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

spowelljr commented 2 months ago

/ok-to-test

minikube-pr-bot commented 2 months ago

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19511) |
+----------------+----------+---------------------+
| minikube start | 49.8s    | 49.5s               |
| enable ingress | 14.7s    | 15.0s               |
+----------------+----------+---------------------+
Times for minikube ingress: 15.0s 14.5s 14.5s 14.5s 15.0s Times for minikube (PR 19511) ingress: 15.0s 14.5s 15.0s 15.0s 15.5s Times for minikube start: 46.7s 49.7s 52.6s 51.2s 48.8s Times for minikube (PR 19511) start: 50.1s 48.1s 49.9s 50.7s 48.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19511) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.3s               |
| enable ingress | 12.8s    | 13.2s               |
+----------------+----------+---------------------+
Times for minikube (PR 19511) start: 23.8s 21.8s 21.9s 21.8s 22.5s Times for minikube start: 21.7s 21.7s 24.6s 20.2s 24.2s Times for minikube ingress: 12.8s 12.3s 12.8s 12.8s 13.3s Times for minikube (PR 19511) ingress: 13.8s 13.3s 13.8s 12.3s 12.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19511) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.4s               |
| enable ingress | 37.4s    | 36.4s               |
+----------------+----------+---------------------+
Times for minikube start: 22.4s 23.0s 19.4s 20.9s 22.8s Times for minikube (PR 19511) start: 20.8s 19.9s 23.7s 22.8s 20.0s Times for minikube ingress: 39.3s 39.8s 39.3s 29.9s 38.8s Times for minikube (PR 19511) ingress: 38.8s 23.8s 39.8s 39.8s 39.8s
minikube-pr-bot commented 2 months ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio_arm64 (3 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 6.82% (chart)
Docker_Linux_crio (3 failed) TestFunctional/parallel/ImageCommands/ImageLoadFromFile(gopogh) 6.86% (chart)
Docker_Linux_containerd (1 failed) TestDownloadOnly/v1.31.0/json-events(gopogh) 0.00% (chart)
KVM_Linux_containerd (1 failed) TestFunctional/parallel/MountCmd/specific-port(gopogh) 1.14% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [spowelljr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment